[PATCH] D129653: isInductionPHI - Add some safety checks

[Zaara Syeda via Phabricator via llvm-commits]

syzaara added a comment.

In D129653#3648500 <https://reviews.llvm.org/D129653#3648500>, @nickdesaulniers wrote:

> Untested, but LGTM; thanks for this cleanup!

I'm not quite sure how to test this. I could test it through my use case in rewriteLoopExitValues for which I have tests already upstream (so it's more of an NFC). Or,  it could be through some unit tests for isInductionPHI itself, I see tests in llvm/unittests/Analysis/IVDescriptorsTest.cpp. But these checks seem too trivial to add unit tests for. Is it okay to commit this without further testing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129653/new/

https://reviews.llvm.org/D129653