[PATCH] D129656: Mark the llvm.vector.insert/extract intrinsics speculatable

David Kreitzer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 09:06:45 PDT 2022


dkreitzer created this revision.
dkreitzer added reviewers: craig.topper, frasercrmck, bsmith, nlopes.
Herald added subscribers: luke957, StephenFan, jdoerfert, luismarques, s.egerton, PkmX, simoncook, kristof.beyls, arichardson.
Herald added a project: All.
dkreitzer requested review of this revision.
Herald added subscribers: llvm-commits, alextsao1999, pcwang-thead.
Herald added a project: LLVM.

This patch is the follow-up from this discourse topic <https://discourse.llvm.org/t/clarify-llvm-vector-insert-llvm-vector-extract-intrinsic-semantics/63530>.

The discourse thread has the explanation for why I believe this change to be correct, and I am hoping reviewers can agree on behalf of AArch64 & RISCV targets.

Another thing I noticed that I'd like to fix in a follow-up patch: The language reference claims that you cannot insert/extract a scalable vector into/from a fixed-width vector, but the verifier doesn't actually check this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129656

Files:
  llvm/docs/LangRef.rst
  llvm/include/llvm/IR/Intrinsics.td
  llvm/test/Transforms/SimplifyCFG/speculate-vector-insert-extract.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129656.444247.patch
Type: text/x-patch
Size: 5730 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220713/be539cc5/attachment.bin>


More information about the llvm-commits mailing list