[PATCH] D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser

Victor Campos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 06:05:49 PDT 2022


vhscampos updated this revision to Diff 444242.
vhscampos added a comment.

Adding testcases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129631/new/

https://reviews.llvm.org/D129631

Files:
  llvm/lib/Support/ARMAttributeParser.cpp
  llvm/test/MC/ARM/directive-eabi_attribute-cpu_arch-armv8a.s
  llvm/test/MC/ARM/directive-eabi_attribute-cpu_arch-armv8r.s


Index: llvm/test/MC/ARM/directive-eabi_attribute-cpu_arch-armv8r.s
===================================================================
--- /dev/null
+++ llvm/test/MC/ARM/directive-eabi_attribute-cpu_arch-armv8r.s
@@ -0,0 +1,11 @@
+@ RUN: llvm-mc -triple arm -filetype asm -o - %s | FileCheck %s
+@ RUN: llvm-mc -triple arm -filetype obj -o - %s | llvm-readobj -A - | \
+@ RUN: FileCheck %s --check-prefix=CHECK-OBJ
+
+.eabi_attribute Tag_CPU_arch, 15
+@ CHECK:          .eabi_attribute 6, 15 @ Tag_CPU_arch
+@ CHECK-OBJ:      Attribute
+@ CHECK-OBJ: Tag: 6
+@ CHECK-OBJ-NEXT: Value: 15
+@ CHECK-OBJ-NEXT: TagName: CPU_arch
+@ CHECK-OBJ-NEXT: Description: ARM v8-R
Index: llvm/test/MC/ARM/directive-eabi_attribute-cpu_arch-armv8a.s
===================================================================
--- /dev/null
+++ llvm/test/MC/ARM/directive-eabi_attribute-cpu_arch-armv8a.s
@@ -0,0 +1,11 @@
+@ RUN: llvm-mc -triple arm -filetype asm -o - %s | FileCheck %s
+@ RUN: llvm-mc -triple arm -filetype obj -o - %s | llvm-readobj -A - | \
+@ RUN: FileCheck %s --check-prefix=CHECK-OBJ
+
+.eabi_attribute Tag_CPU_arch, 14
+@ CHECK:          .eabi_attribute 6, 14 @ Tag_CPU_arch
+@ CHECK-OBJ:      Attribute
+@ CHECK-OBJ: Tag: 6
+@ CHECK-OBJ-NEXT: Value: 14
+@ CHECK-OBJ-NEXT: TagName: CPU_arch
+@ CHECK-OBJ-NEXT: Description: ARM v8-A
Index: llvm/lib/Support/ARMAttributeParser.cpp
===================================================================
--- llvm/lib/Support/ARMAttributeParser.cpp
+++ llvm/lib/Support/ARMAttributeParser.cpp
@@ -85,7 +85,7 @@
   static const char *strings[] = {
     "Pre-v4", "ARM v4", "ARM v4T", "ARM v5T", "ARM v5TE", "ARM v5TEJ", "ARM v6",
     "ARM v6KZ", "ARM v6T2", "ARM v6K", "ARM v7", "ARM v6-M", "ARM v6S-M",
-    "ARM v7E-M", "ARM v8", nullptr,
+    "ARM v7E-M", "ARM v8-A", "ARM v8-R",
     "ARM v8-M Baseline", "ARM v8-M Mainline", nullptr, nullptr, nullptr,
     "ARM v8.1-M Mainline", "ARM v9-A"
   };


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129631.444242.patch
Type: text/x-patch
Size: 1940 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220713/b4e7cccd/attachment.bin>


More information about the llvm-commits mailing list