[PATCH] D129634: [X86] Fix updating LiveVariables in convertToThreeAddress

Wed Jul 13 05:25:15 PDT 2022

foad added reviewers: craig.topper, RKSimon.
foad added inline comments.
Herald added a subscriber: StephenFan.

================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:1390
     NewMI = MIB;
-
+    if (LV && SrcReg != Src.getReg())
+      LV->getVarInfo(SrcReg).Kills.push_back(NewMI);
----------------
I'm not proud of this patch because it adds duplicated code like this after almost every call to classifyLEAReg. There may be better ways to do this, by completely rethinking the way that convertToThreeAddress updates LiveVariables.

On the other hand LiveVariables is supposed to go away in favour of LiveIntervals, so does it really matter?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129634/new/

https://reviews.llvm.org/D129634