[PATCH] D129566: AMDGPU: Turn off force init 16 input SGPRS for pal

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

To be honest, it looks like the entire function should only be called for ROCm-style compute. It shouldn't be used for either PAL or Mesa. Except maybe the Info.hasPrivateSegmentWaveByteOffset part? I'm not sure about that last one. But none of the hasWorkGroupFoo stuff should apply as far as I can tell.

And by the way, why is that a function of the OS? Shouldn't it be a function of the calling convention?

So to sum up: I agree with Tim and David that this code shouldn't be applied in the PAL/Mesa case (they both need their own fix for this) -- though keeping the assertion alive somewhere would be good. But it's not clear to me that this patch is the right way to do it.

It feels somehwat dubious that this entire method runs for an amdgpu_cs calling convention, but perhaps we don't need to change that, given the method already has an `IsShader` check. How about: apply the init16 bug workaround only if `!IsShader`, but keep the assertion unmodified?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129566/new/

https://reviews.llvm.org/D129566