[PATCH] D129337: [llvm-objcopy][ELF] Add --set-section-type

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with suggested changes.



================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:130
 
  Set the alignment of section ``<section>`` to `<align>``. Can be specified
  multiple times to update multiple sections.
----------------
Unrelated, but if you get a moment whilst updating this doc, would you mean fixing the typo with the uneven ` characters around "<align>", please?


================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:174
+
+ For ELF objects, set the type for a given section to the integer <type>.
+
----------------
I suggest adopting the wording that --set-section-alignment uses. Something like this would be good:

```
Set the type of section ``<section>`` to the integer ``<type>``. Can be specified multiple times to update multiple sections.
```

As this option is ELF-only, it should be put under the "ELF-SPECIFIC OPTIONS" section of the doc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129337/new/

https://reviews.llvm.org/D129337