[PATCH] D129073: [AMDGPU] Combine s_or_saveexec, s_xor instructions.

[Thomas Symalla via Phabricator via llvm-commits]

tsymalla added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:830-831
+
+  Changed |= optimizeOrSaveexecXorSequences();
+  Changed |= optimizeVCmpxAndSaveexecSequences();
 
----------------
arsenm wrote:
> Why do you need to collect every instance in the function before processing them? Each of these can be handled standalone?
I find that more convenient and easier to follow, especially if the optimization handles a bunch of cases. Instead of mixing the find pattern-do combine step, I prefer to first exclude all irrelevant matchings and then just transform the findings one by another.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129073/new/

https://reviews.llvm.org/D129073