[PATCH] D128958: Add assembler plumbing for sanitize_memtag

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 16:57:13 PDT 2022


eugenis added inline comments.


================
Comment at: llvm/include/llvm/MC/MCAsmInfo.h:777
 
+  MCSymbolAttr getTaggedAttr() const { return TaggedAttr; }
+
----------------
getMemtagAttr ?


================
Comment at: llvm/include/llvm/MC/MCSymbolELF.h:47
+  bool isMemoryTagged() const;
+  void setTagged(bool Tagged);
+
----------------
Why are these names so random?

```
getMemTag()
setMemTag()
```

or something similar with "is"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128958/new/

https://reviews.llvm.org/D128958



More information about the llvm-commits mailing list