[PATCH] D124425: MemoryBuiltins: replace most users of isFreeCall with isFreeLikeCall
Augie Fackler via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 12 15:50:52 PDT 2022
durin42 added a comment.
In D124425#3582970 <https://reviews.llvm.org/D124425#3582970>, @bogner wrote:
> This affects tests a bit more than I'd expect - I guess these are test issues where we weren't calling the builtin free for one reason or another. Would it be better to fix up the tests so that they do the right things without this change beforehand to make it obvious that this isn't changing behaviour in a weird way?
Maybe. Do you have some exemplars in mind here that change in ways you don't expect? I've been looking at this patch so long it just seems obviously-the-way-it-is to me now...for good or for ill.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124425/new/
https://reviews.llvm.org/D124425
More information about the llvm-commits
mailing list