[PATCH] D123090: MemoryBuiltins: start using properties of functions

Augie Fackler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 15:49:18 PDT 2022


durin42 added a comment.

In D123090#3564542 <https://reviews.llvm.org/D123090#3564542>, @nikic wrote:

> In terms of general approach, we'd probably be better off adding support for the attributes in MemoryBuiltins (with a test on a custom allocation function somewhere), and then do the removal from the tables separately (that's also the bit that needs test adjustment).

IOW: implement everything including D123091 <https://reviews.llvm.org/D123091>, then do the removal at the end? I can do that restructuring if that's what you have in mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123090/new/

https://reviews.llvm.org/D123090



More information about the llvm-commits mailing list