[PATCH] D122255: Meta directive runtime support

[Abid via Phabricator via llvm-commits]

abidmalikwaterloo added a comment.

Ping!



================
Comment at: clang/lib/AST/OpenMPClause.cpp:1614-1617
+  if (Node->getTI().Sets.size() == 0) {
+    OS << "default(";
+    return;
+  }
----------------
ABataev wrote:
> Is this correct? Just `default(` is expected to be printed?
This function is called from `StmtPrinter::PrintOMPExecutableDirective ` in `StmtPrinter.CPP`. The enclosed Directive and the second matching brace will be printed. See line # 670 in `StmtPrinter.CPP`


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:2433
 Parser::ParseOpenMPDeclarativeOrExecutableDirective(ParsedStmtContext StmtCtx) {
+// need to check about the following
   static bool ReadDirectiveWithinMetadirective = false;
----------------
ABataev wrote:
> What is this?
comment removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122255/new/

https://reviews.llvm.org/D122255