[PATCH] D129519: [Symbolizer] Implement contextual symbolizer markup elements.

Daniel Thornburgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 10:55:46 PDT 2022


mysterymath added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:254-255
   :doc:`Symbolizer Markup </SymbolizerMarkupFormat>` into human-readable form,
   and prints the results to standard output. Presently, only the following
   markup elements are supported:
 
----------------
jhenderson wrote:
> The term "only" implies there are many other elements that aren't supported (at least more than the number of supported elements). Is that still the case? If not, delete "only".
Yep, still far more unimplemented than implemented. It's also not actually possble to use the markup for symbolization tasks yet, this just establishes the baseline.
SGTM on the language though; it should probably become just a list of supported elements once there's enough present to actually be useful, then a list of unsupported elements once it's past the halfway point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129519/new/

https://reviews.llvm.org/D129519



More information about the llvm-commits mailing list