[PATCH] D129566: AMDGPU: Turn off force init 16 input SGPRS for pal
David Stuttard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 12 09:38:04 PDT 2022
dstuttard added a comment.
In D129566#3645692 <https://reviews.llvm.org/D129566#3645692>, @arsenm wrote:
> I don't see why PAL would get special treatment here. I think the problem is we don't really try to account for the formal arguments in the user SGPR count. A better fix would be to track that accurately
Pal uses a completely different approach where the front end does all the setup for the user sgprs and passes the info in via pal metadata. The backend can override/modify this, but for user data sgprs is generally doesn't. Moving the pal shaders to use the same model would be a fairly big piece of work, and would mean adding quite a lot of extra code to the backend that's specific to pal.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129566/new/
https://reviews.llvm.org/D129566
More information about the llvm-commits
mailing list