[PATCH] D129381: [AMDGPU][CodeGen] Support (register + immediate) SMRD offsets.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 09:10:36 PDT 2022


kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1978
+    assert(!Imm32Only);
+    SDValue B;
+    return SelectSMRDBaseOffset(Addr, B, nullptr, Offset) &&
----------------
arsenm wrote:
> I don't follow how/why B is being discarded
It's being split into `SBase` and `SOffset`, which we both return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129381/new/

https://reviews.llvm.org/D129381



More information about the llvm-commits mailing list