[PATCH] D129518: [BOLT] Add function layout class

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 05:45:07 PDT 2022


yota9 added inline comments.


================
Comment at: bolt/include/bolt/Core/BinaryBasicBlock.h:678
+
+  void setIsCold(const bool Flag) { FragmentNum = Flag ? 1 : 0; }
 
----------------
Hello, I didn't investigate this patch carefully for now, but why FragmentNum needs to be unsigned? It seems it is used like previously used isCold flag. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129518/new/

https://reviews.llvm.org/D129518



More information about the llvm-commits mailing list