[PATCH] D129523: [Reassociate] Enable FP reassociation via 'reassoc' and 'nsz'

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 05:27:51 PDT 2022


spatel added a comment.

I support the direction. IIRC, fixing FMF requirements for -reassociate came up during similar patches that were made to fix -instcombine like D47335 <https://reviews.llvm.org/D47335>. This just got lost in my bug queue.

Using `I->isAssociative()` directly seems like the right change rather than adding a wrapper (agree with inline comment from @nikic). Any uses of `isFast()` in IR are bogus at this point (that API should be deprecated) - there is no transform that requires all of the individual FMF.

If we can fix the regressions as an independent patch, that would be ideal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129523/new/

https://reviews.llvm.org/D129523



More information about the llvm-commits mailing list