[PATCH] D125783: [llvm-dva] 08 - ELF Reader
Carlos Alberto Enciso via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 12 04:26:34 PDT 2022
CarlosAlbertoEnciso added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Readers/LVELFReader.h:132-133
+ Obj(Obj) {}
+ LVELFReader(const LVELFReader &) = delete;
+ LVELFReader &operator=(LVELFReader const &) = delete;
+ ~LVELFReader() = default;
----------------
psamolysov wrote:
> Just a nit. In the copy constructor a west-const is used while in the copy assignment operation an east-const. Also there are some east-const for return values (in `LVSymbols const &GetSymbolsWithLocations() const` member for example). Could a single style be chosen?
Changed across all patches to use `west-const` in copy constructors and copy assignments.
Changed to `const LVSymbols const &GetSymbolsWithLocations()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125783/new/
https://reviews.llvm.org/D125783
More information about the llvm-commits
mailing list