[PATCH] D129357: [LoongArch] Implement OR combination to generate bstrins.w/d

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/bstrins_d.ll:136
+
+;; Test that bstrins.d is not generated becasue constant OR operand
+;; doesn't fit into bits cleared by constant AND operand.
----------------
typo: `because`.

You can include the fix in the next revision, together with the other changes you plan to make. No need to push a new revision just for this, for your convenience (and less email clutter for everyone).


================
Comment at: llvm/test/CodeGen/LoongArch/bstrins_w.ll:148
+
+;; Test that bstrins.w is not generated becasue constant OR operand
+;; doesn't fit into bits cleared by constant AND operand.
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129357/new/

https://reviews.llvm.org/D129357