[PATCH] D129370: [SimplifyCFG] Allow SimplifyCFG hoisting to skip over non-matching instructions
Momchil Velikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 12 02:56:10 PDT 2022
chill marked 3 inline comments as done.
chill added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1463
+// single-predecessor basic blocks only, then it's sufficient to know the
+// instruction operands are not in the same basic block as the instruction.
+ for (Value *Op : I->operands()) {
----------------
nikic wrote:
> What does this have to do with the single predecessor? Doesn't this generally hold?
Indeed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129370/new/
https://reviews.llvm.org/D129370
More information about the llvm-commits
mailing list