[PATCH] D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option

[mgabka via Phabricator via llvm-commits]

mgabka added a subscriber: david-arm.
mgabka added a comment.

It looks reasonable to me.
The main issue we saw in the past was assertion failure when the cost for gather/scatter wasn't implemented, but you are saying that now it is simply returning invalid cost so the type based cost model for gather/scatter is not needed.
But I guess it does not hurt to add it.
@david-arm you did some work on the cost model for gather/scatter from what I can see, could you have a look if you agree with the proposed changes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129109/new/

https://reviews.llvm.org/D129109