[PATCH] D129544: [RISCV][test] Add test of binop followed by extractelement.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 01:40:08 PDT 2022


frasercrmck added a comment.

I've only briefly looked at `shouldScalarizeBinop` but it sounds like it should theoretically work for scalable vectors (barring an initial check against `BUILD_VECTOR`) - should we add some scalable-vector tests here too while we're at it? I don't know if you're planning on that change in the future but having consistency sounds desirable to me. Or at least we could make it clear this patch adds fixed-vector tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129544/new/

https://reviews.llvm.org/D129544



More information about the llvm-commits mailing list