[PATCH] D129525: [GlobalOpt] Drop SRA split limit for struct types.
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 12 00:29:54 PDT 2022
nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.
This will also bypass the check if you have an array that is nested inside a struct. Besides, I don't think we should be making decisions based on the global value type here, which is a another vacuous concept that shouldn't exist (e.g. in rust the global type will often be something like `[N x i8]`, in "bag of bytes" representation).
Does raising the limit to the next power of two cover your test case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129525/new/
https://reviews.llvm.org/D129525
More information about the llvm-commits
mailing list