[PATCH] D129263: Windows packaging script. Check administrator permissions and/or 7-Zip version.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:23
+
+REM Unique temporal filename to use by the 'mklink' command.
+set "link_name=%temp%\%username%_%random%_%random%.tmp"
----------------
hans wrote:
> I think you mean "temporary" instead of "temporal", here and below.
Changed to `temporary`.


================
Comment at: llvm/utils/release/build_llvm_release.bat:24
+REM Unique temporal filename to use by the 'mklink' command.
+set "link_name=%temp%\%username%_%random%_%random%.tmp"
+
----------------
hans wrote:
> I'd suggest moving this line to where link_name is first used below.
Moved `link_name` inside the `if`.


================
Comment at: llvm/utils/release/build_llvm_release.bat:21
+
+REM Check for correct 7-zip version and/or administrator permissions.
+for /f "delims=" %%i in ('7z.exe ^| findstr /r "2[1-9]"') do set version=%%i
----------------
hans wrote:
> Nit: maybe drop "correct" since they're all correct. How about just "Check 7-zip version and/or administrator permissions."
Replaced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129263/new/

https://reviews.llvm.org/D129263