[PATCH] D128382: [LLD] Two tweaks to symbol ordering scheme

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1323
   for (InputSection *isec : isd->sections) {
+    if (executableOutputSection)
+      totalSize += isec->getSize();
----------------
yozhu wrote:
> MaskRay wrote:
> > Delete `if (executableOutputSection)`
> If output section is executable, we don't need to count `totalSize`.
Since `getSize` actually takes not-too-few instructions. Keeping `if (executableOutputSection)` is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128382/new/

https://reviews.llvm.org/D128382