[PATCH] D128382: [LLD] Two tweaks to symbol ordering scheme

YongKang Zhu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 22:16:52 PDT 2022


yozhu added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1323
   for (InputSection *isec : isd->sections) {
+    if (executableOutputSection)
+      totalSize += isec->getSize();
----------------
MaskRay wrote:
> Delete `if (executableOutputSection)`
If output section is executable, we don't need to count `totalSize`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128382/new/

https://reviews.llvm.org/D128382



More information about the llvm-commits mailing list