[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 22:12:32 PDT 2022


xiangzhangllvm added a comment.

In D129352#3644205 <https://reviews.llvm.org/D129352#3644205>, @craig.topper wrote:

> The GEP optimization isn't mandatory. It will only generate worse code. CodeGenPrepare doesn't run at -O0 so nothing in it can be mandatory.

Yes, and for this patch, I think it may not worse, instruction optimization just fine tuning the CFG, if the BB has optimized, it will has little optimization chance again.  I tested the spec performance, it has almost no affect.
If we not consider limited the building time, it very hurt to the JIT compiler. (in fact, it is our dpc++ user blame such compiling time)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352



More information about the llvm-commits mailing list