[PATCH] D129288: [IR] Don't use blockaddresses as callbr arguments

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/test/Verifier/callbr.ll:67-76
-;; Ensure you cannot specify the same label as both normal and indirect targets.
-; CHECK: Duplicate callbr destination!
-; CHECK-NEXT: #test5
-define i32 @test5() {
-entry:
-  %ret = callbr i32 asm sideeffect "#test5", "=r,i"(i8* blockaddress(@test5, %both)) to label %both [label %both]
-
----------------
nikic wrote:
> nickdesaulniers wrote:
> > I think we want to retain this test? The important part is that `to label %both [label %both]` not be modified.
> Do you mean as a CHECK-NOT test, to check that duplicate successors are allowed now?
Ah, nevermind. I see we have test coverage of that in `@duplicate_normal_and_indirect_dest` in duplicate_normal_and_indirect_dest.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129288/new/

https://reviews.llvm.org/D129288