[PATCH] D129505: [GISel] Check useLoadStackGuardNode() before generating LOAD_STACK_GUARD

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2083
+    if (TLI.useLoadStackGuardNode()) {
+      GuardVal = MRI->createGenericVirtualRegister(PtrTy);
+      getStackGuard(GuardVal, MIRBuilder);
----------------
Kai wrote:
> arsenm wrote:
> > Don't see why getStackGuard doesn't just return the virtual register it creates itself
> Sorry, do you mean that getStackGuard() should create the virtual register? Currently it uses the register passed as argument.
> I guess that should work as LLVM always uses a pointer as type for the stack guard value.
Yes. These APIs that take output registers are a bit awkward


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129505/new/

https://reviews.llvm.org/D129505