[PATCH] D113734: [llvm-objcopy][MachO] Add llvm-strip support for newer load commands
Keith Smiley via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 11 13:22:18 PDT 2022
keith added a comment.
In D113734#3641737 <https://reviews.llvm.org/D113734#3641737>, @BertalanD wrote:
> @keith is there a reason `Object::ExportsTrie` was added instead of reusing the `Exports` member? I read in D107673 <https://reviews.llvm.org/D107673> that `LC_DYLD_EXPORTS_TRIE` and `LD_DYLD_INFO` are mutually exclusive, so we could re-use the same trie for both load commands.
Interesting! I didn't consider this option when I was writing this IIRC, I was just mirroring the 1:1 command to member. So if that works that sounds fine to me!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113734/new/
https://reviews.llvm.org/D113734
More information about the llvm-commits
mailing list