[PATCH] D129507: [llvm-objcopy] Add option to dump embedded offloading images

Mon Jul 11 12:29:56 PDT 2022

jhuber6 marked an inline comment as done.
jhuber6 added a comment.

In D129507#3643246 <https://reviews.llvm.org/D129507#3643246>, @MaskRay wrote:

> The feature doesn't fit into llvm-objcopy's purpose. llvm-objcopy is a binary manipulation tool which only understands ELF. `--dump-offloading` seems to parse the content using knowledge of the underlying format.

I see, I simply chose it because it had a similar feature for `--dump-sections`. Should this be placed in `llvm-objdump` as well then?

In D129507#3643241 <https://reviews.llvm.org/D129507#3643241>, @tra wrote:

> It would be great to allow dumping  all offloading binaries at once. E.g. something like `--dump-offloading all=file-name` or just `--dump-offloading file-name` which would save all binaries into `file-name.0` .. `file-name.N`.

That's a good idea, I'll add it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129507/new/

https://reviews.llvm.org/D129507