[PATCH] D129407: [InstrProf] Allow CSIRPGO function entry coverage

Mon Jul 11 11:32:57 PDT 2022

ellis added a comment.

In D129407#3642933 <https://reviews.llvm.org/D129407#3642933>, @phosek wrote:

> Is there a test covering this?

The only different between `-fprofile-generate` and `-fcs-profile-generate` is when the `pgo-instr-gen` pass is added, so I don't think an explicit test is necessary. We have lots of tests in `test/Transforms/PGOProfile` that use `opt < %s -passes=pgo-instr-gen` that uses this code to inject the `llvm.instrprof` intrinsics, but I couldn't find test that trigger this using the frontend flags.

That being said, I would be happy to add some tests if that's what we want. I think it would need to be a clang test that checks if the instrumentation code is injected correctly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129407/new/

https://reviews.llvm.org/D129407