[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

As I mentioned, the proper approach is to add zstd functionality along with the CMake change, instead of adding CMake to all llvm-project components without a way to test them.



================
Comment at: lld/test/lit.site.cfg.py.in:21
 config.have_zlib = @LLVM_ENABLE_ZLIB@
+config.have_zstd = @LLVM_ENABLE_ZSTD@
 config.have_libxar = @LLVM_HAVE_LIBXAR@
----------------
ckissane wrote:
> ckissane wrote:
> > MaskRay wrote:
> > > MaskRay wrote:
> > > > This needs a change in lld/test/CMakeLists.txt
> > > > 
> > > > Looks like you haven't run `ninja check-lld` as I mentioned.
> > > Actually I am preparing a lld patch and you probably should drop have_zstd from lld/ for this patch.
> > I get this when I try to run that:
> > `ninja: error: unknown target 'check-lld', did you mean 'check-lit'?`
> Got it
During cmake, ensure that LLVM_ENABLE_PROJECTS contains `lld`

I posted the patch link to another patch of yours: https://reviews.llvm.org/D129406




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465