[PATCH] D129484: [llvm][docs] Fix typos to say subclasses need to override virtual methods but not overload
Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 11 09:55:21 PDT 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG370266aec543: [llvm][docs] Fix typos to say subclasses need to override virtual methods but… (authored by RamNalamothu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129484/new/
https://reviews.llvm.org/D129484
Files:
llvm/docs/WritingAnLLVMPass.rst
Index: llvm/docs/WritingAnLLVMPass.rst
===================================================================
--- llvm/docs/WritingAnLLVMPass.rst
+++ llvm/docs/WritingAnLLVMPass.rst
@@ -377,7 +377,7 @@
declarations.
To write a correct ``ModulePass`` subclass, derive from ``ModulePass`` and
-overload the ``runOnModule`` method with the following signature:
+override the ``runOnModule`` method with the following signature:
The ``runOnModule`` method
^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -485,7 +485,7 @@
Implementing a ``FunctionPass`` is usually straightforward (See the :ref:`Hello
World <writing-an-llvm-pass-basiccode>` pass for example).
-``FunctionPass``\ es may overload three virtual methods to do their work. All
+``FunctionPass``\ es may override three virtual methods to do their work. All
of these methods should return ``true`` if they modified the program, or
``false`` if they didn't.
@@ -550,7 +550,7 @@
``LoopPass`` subclasses are allowed to update loop nest using ``LPPassManager``
interface. Implementing a loop pass is usually straightforward.
-``LoopPass``\ es may overload three virtual methods to do their work. All
+``LoopPass``\ es may override three virtual methods to do their work. All
these methods should return ``true`` if they modified the program, or ``false``
if they didn't.
@@ -611,7 +611,7 @@
region is processed last.
``RegionPass`` subclasses are allowed to update the region tree by using the
-``RGPassManager`` interface. You may overload three virtual methods of
+``RGPassManager`` interface. You may override three virtual methods of
``RegionPass`` to implement your own region pass. All these methods should
return ``true`` if they modified the program, or ``false`` if they did not.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129484.443677.patch
Type: text/x-patch
Size: 1760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220711/1f9b7005/attachment.bin>
More information about the llvm-commits
mailing list