[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

[Bing Yu via Phabricator via llvm-commits]

yubing added a comment.

In D129352#3641942 <https://reviews.llvm.org/D129352#3641942>, @xiangzhangllvm wrote:

> In D129352#3641747 <https://reviews.llvm.org/D129352#3641747>, @yubing wrote:
>
>> optimizeGatherScatterInst is a mandatory procedure where codegenpre convert GEP(splat base ptr) into GEP(scalar base ptr) since SelectionDAGBuilder only handle GEP(scalar base ptr). please take a look at optimizeGatherScatterInst's comments
>
> Thanks a lot! But this has been converted in the first time. We just skip BB which has been optimized.

if GEP and Gather/Scatter are not in the same bb, we don't do optimize GEP in the first round. When it is second round and GEP and Gather/Scatter are put in the same bb, your code will let the GEP's optimization not happen.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352