[PATCH] D129263: Windows packaging script. Check administrator permissions and/or 7-Zip version.

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.

still lgtm (just a few nits)



================
Comment at: llvm/utils/release/build_llvm_release.bat:23
+
+REM Unique temporal filename to use by the 'mklink' command.
+set "link_name=%temp%\%username%_%random%_%random%.tmp"
----------------
I think you mean "temporary" instead of "temporal", here and below.


================
Comment at: llvm/utils/release/build_llvm_release.bat:24
+REM Unique temporal filename to use by the 'mklink' command.
+set "link_name=%temp%\%username%_%random%_%random%.tmp"
+
----------------
I'd suggest moving this line to where link_name is first used below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129263/new/

https://reviews.llvm.org/D129263