[PATCH] D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP.

Mon Jul 11 01:31:58 PDT 2022

clementval added inline comments.

================
Comment at: mlir/lib/Target/LLVMIR/Dialect/Utils/DirectiveToLLVMIRTranslation.cpp:315
+  if (failed(processOperands(builder, moduleTranslation, op, copyOperands,
                              totalNbOperand, kCopyFlag | kHoldFlag, flags,
                              names, index, mapperAllocas)))
----------------
For example the `kHoldFlag` here is a specific OpenACC extension so it's wrong to use it for OpenMP. See https://reviews.llvm.org/D106509 and https://reviews.llvm.org/D106510 for references. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127037/new/

https://reviews.llvm.org/D127037