[PATCH] D128899: [LoongArch] Add codegen support for fpround, fpextend and converting between signed integer and floating-point

Mon Jul 11 01:23:09 PDT 2022

gonglingqin added inline comments.

================
Comment at: llvm/lib/Target/LoongArch/LoongArchFloat32InstrInfo.td:25
+    : SDNode<"LoongArchISD::MOVGR2FR_W_LA64", SDT_LoongArchMOVGR2FR_W_LA64>;
+def loongarch_movfr2gr_s_anyext_la64
+    : SDNode<"LoongArchISD::MOVFR2GR_S_LA64", SDT_LoongArchMOVFR2GR_S_LA64>;
----------------
xen0n wrote:
> What does `anyext` mean? Either this isn't meaningful and should be removed, or an explanatory comment should be around.
Thanks,  `anyext` is not very useful for this node, I will remove it

================
Comment at: llvm/lib/Target/LoongArch/LoongArchFloat64InstrInfo.td:201
+
+/// Float conversion operations
+
----------------
xen0n wrote:
> nit: "FP" or "Floating-point" for consistency.
Thanks, , I will change it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128899/new/

https://reviews.llvm.org/D128899