[PATCH] D129468: [NFC] Fix compile time regression seen on some benchmarks after a630ea3003 commit

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 01:17:59 PDT 2022


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

Compile-time: http://llvm-compile-time-tracker.com/compare.php?from=9b9ff63b03eae1027aa75d9c2b37b98b10a49c66&to=f94121930dade0677f3b566e65812975abd3a39c&stat=instructions



================
Comment at: llvm/include/llvm/IR/Metadata.h:1043
+        return SmallNumOps;
+      return operands().size();
+    }
----------------
Directly use `getLarge().size()` here?


================
Comment at: llvm/lib/Analysis/TypeBasedAliasAnalysis.cpp:306
     bool NewFormat = isNewFormat();
+    const ArrayRef<MDOperand> Operands(Node->op_begin(), Node->op_end());
+    const unsigned NumOperands = Operands.size();
----------------
Can use `Node->operands()` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129468/new/

https://reviews.llvm.org/D129468



More information about the llvm-commits mailing list