[PATCH] D129378: [LLD][COFF] Ignore DEBUG_S_XFGHASH_TYPE/VIRTUAL

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

I think this looks mostly good to me.



================
Comment at: lld/COFF/PDB.cpp:816
+    case DebugSubsectionKind::XfgHashVirtual:
+      break;
+
----------------
You mentioned elsewhere that there doesn't seem to be any testcases for other similarly ignored ones - I think it's fair to add this without an exact testcase here too.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/FormatUtil.cpp:70
+      RETURN_CASE(DebugSubsectionKind, XfgHashType, "xfg hash type");
+      RETURN_CASE(DebugSubsectionKind, XfgHashVirtual, "xfg hash virtual");
     }
----------------
Is there any testcase for these ones, where the new types could easily be added?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129378/new/

https://reviews.llvm.org/D129378