[PATCH] D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D126827#3613023 <https://reviews.llvm.org/D126827#3613023>, @wlei wrote:

> changed all offset usage to preferred address based virtual address

Thanks for the work! It should be more reliable and also looks cleaner.



================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:745
+        if (UseLoadableSegmentAsBase) {
+          Start -= Binary->getFirstLoadableAddress();
+          End -= Binary->getFirstLoadableAddress();
----------------
I'm a bit confused here. What is the semantics of using both offset and LoadableSegmentAsBase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126827/new/

https://reviews.llvm.org/D126827