[PATCH] D129402: [RISCV] Teach shouldConvertConstantLoadToIntImm that constant materialization can use constant pools.

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 16:18:42 PDT 2022


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1180-1181
+  // check useConstantPoolForLargeInts.
+  // TODO: Should we have a different threshold or do this only when we're
+  // definitely going to emit a constant pool?
+
----------------
I can't think of a reason why it should be different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129402/new/

https://reviews.llvm.org/D129402



More information about the llvm-commits mailing list