[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 15:48:43 PDT 2022


MaskRay reopened this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

This patch has changed a lot from what I have reviewed. The CMake change should be added along with `llvm::compression::zstd::*` functions.
Otherwise the change just introduces some CMake variables which cannot be tested.

Since you haven't touched flang, compiler-rt, etc. The patch should not updated their CMake files.

For lld/ELF, I've created D129406 <https://reviews.llvm.org/D129406> to add the support. It will need to wait until you have landed these zstd changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465



More information about the llvm-commits mailing list