[PATCH] D129260: [BOLT][AArch64] Handle gold linker veneers

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 14:52:51 PDT 2022


rafauler added inline comments.


================
Comment at: bolt/include/bolt/Core/BinaryContext.h:647
+  /// and are referenced from BinaryFunction.
+  std::list<std::pair<BinaryFunction *, uint64_t>> InterproceduralReferences;
+
----------------
nit: I suspect btw that a regular "std::vector" makes more sense here (since you're not doing any operation that would be faster with a linked list)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129260/new/

https://reviews.llvm.org/D129260



More information about the llvm-commits mailing list