[PATCH] D129392: llvm-dwarfdump: Don't crash if DW_AT_{decl,call}_{file,line} uses signed form

[Pedro Alves via Phabricator via llvm-commits]

palves added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:156-160
+    if (Optional<uint64_t> Val = FormValue.getAsUnsignedConstant()) {
+      OS << *Val;
+    } else {
+      FormValue.dump(OS, DumpOpts);
+    }
----------------
dblaikie wrote:
> Ah, removed these in a follow-up commit ( 84960896236338eb1c7b30f34041214e64db0bd1 )
Cool, thank you very much, and sorry for the extra work.  Much appreciated!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129392/new/

https://reviews.llvm.org/D129392