[PATCH] D129392: llvm-dwarfdump: Don't crash if DW_AT_{decl,call}_{file,line} uses signed form

[Pedro Alves via Phabricator via llvm-commits]

palves added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:156-160
+    if (Optional<uint64_t> Val = FormValue.getAsUnsignedConstant()) {
+      OS << *Val;
+    } else {
+      FormValue.dump(OS, DumpOpts);
+    }
----------------
palves wrote:
> dblaikie wrote:
> > Generally LLVM code doesn't put {} on single-line blocks like these.
> I think I put those in to avoid dangling-else warnings.
Turns out there's no dangling-else warning here.  I've uploaded an update to removes the unnecessary braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129392/new/

https://reviews.llvm.org/D129392