[PATCH] D129392: llvm-dwarfdump: Don't crash if DW_AT_{decl,call}_{file,line} uses signed form

[Pedro Alves via Phabricator via llvm-commits]

palves added a comment.

In D129392#3639787 <https://reviews.llvm.org/D129392#3639787>, @dblaikie wrote:

> Sure, sounds OK.

Thanks!  Could someone merge it for me then?  I don't have write access.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:156-160
+    if (Optional<uint64_t> Val = FormValue.getAsUnsignedConstant()) {
+      OS << *Val;
+    } else {
+      FormValue.dump(OS, DumpOpts);
+    }
----------------
dblaikie wrote:
> Generally LLVM code doesn't put {} on single-line blocks like these.
I think I put those in to avoid dangling-else warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129392/new/

https://reviews.llvm.org/D129392