[PATCH] D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 13:33:59 PDT 2022


nikic added a comment.

Uh, does this actually work in end-to-end tests? From a quick check, on x86_64 the return ABI for `div()` is actually a packed i64 value: https://c.godbolt.org/z/EvTEdKMYG On aarch64 `ldiv()` actually returns a `[2 x i64]`: https://c.godbolt.org/z/W9v1YYbsM

This seems like a morass of different ABIs that your code doesn't account for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129396/new/

https://reviews.llvm.org/D129396



More information about the llvm-commits mailing list