[PATCH] D129323: [llvm] add ztsd compression namespace

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added inline comments.


================
Comment at: llvm/include/llvm/Support/Compression.h:48-51
+static constexpr int NoCompression = -5;
+static constexpr int BestSpeedCompression = 1;
+static constexpr int DefaultCompression = 5;
+static constexpr int BestSizeCompression = 12;
----------------
ckissane wrote:
> ckissane wrote:
> > MaskRay wrote:
> > > leonardchan wrote:
> > > > nit: perhaps this could be an enum with assigned values?
> > > Just use `constexpr`. They are automatically internal linkage
> > I am simply matching the layout of the current zlib namespace here, what is your preference for handling this given that?
> I am simply matching the layout of the current zlib namespace here, what is your preference for handling this given that?
Oh I didn't see that. Disregard this then. Better to maintain consistency with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129323/new/

https://reviews.llvm.org/D129323