[llvm] 96063bf - [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace
Cole Kissane via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 8 11:24:50 PDT 2022
Author: Cole Kissane
Date: 2022-07-08T11:24:45-07:00
New Revision: 96063bfa908865fb102894f9f5afb58c627faf79
URL: https://github.com/llvm/llvm-project/commit/96063bfa908865fb102894f9f5afb58c627faf79
DIFF: https://github.com/llvm/llvm-project/commit/96063bfa908865fb102894f9f5afb58c627faf79.diff
LOG: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace
* Remove crc32 from zlib compression namespace, people should use the `llvm::crc32` instead.
Reviewed By: MaskRay, leonardchan
Differential Revision: https://reviews.llvm.org/D128754
Added:
Modified:
llvm/docs/ReleaseNotes.rst
llvm/include/llvm/Support/Compression.h
llvm/lib/Support/Compression.cpp
llvm/unittests/Support/CompressionTest.cpp
Removed:
################################################################################
diff --git a/llvm/docs/ReleaseNotes.rst b/llvm/docs/ReleaseNotes.rst
index 756ed3e98c3bd..9b0eb6f719a9b 100644
--- a/llvm/docs/ReleaseNotes.rst
+++ b/llvm/docs/ReleaseNotes.rst
@@ -206,6 +206,7 @@ Changes to the C API
introduction of alternatives to zlib compression in the llvm toolchain.
Changes are as follows:
* Relocate the ``llvm::zlib`` namespace to ``llvm::compression::zlib``.
+ * Remove crc32 from zlib compression namespace, people should use the ``llvm::crc32`` instead.
Changes to the Go bindings
--------------------------
diff --git a/llvm/include/llvm/Support/Compression.h b/llvm/include/llvm/Support/Compression.h
index 7d9e12e771f31..6175a85f64b51 100644
--- a/llvm/include/llvm/Support/Compression.h
+++ b/llvm/include/llvm/Support/Compression.h
@@ -41,8 +41,6 @@ Error uncompress(StringRef InputBuffer,
SmallVectorImpl<char> &UncompressedBuffer,
size_t UncompressedSize);
-uint32_t crc32(StringRef Buffer);
-
} // End of namespace zlib
} // End of namespace compression
diff --git a/llvm/lib/Support/Compression.cpp b/llvm/lib/Support/Compression.cpp
index c1a64d56119c3..00f88a3aad314 100644
--- a/llvm/lib/Support/Compression.cpp
+++ b/llvm/lib/Support/Compression.cpp
@@ -83,10 +83,6 @@ Error zlib::uncompress(StringRef InputBuffer,
return E;
}
-uint32_t zlib::crc32(StringRef Buffer) {
- return ::crc32(0, (const Bytef *)Buffer.data(), Buffer.size());
-}
-
#else
bool zlib::isAvailable() { return false; }
void zlib::compress(StringRef InputBuffer,
@@ -102,7 +98,4 @@ Error zlib::uncompress(StringRef InputBuffer,
size_t UncompressedSize) {
llvm_unreachable("zlib::uncompress is unavailable");
}
-uint32_t zlib::crc32(StringRef Buffer) {
- llvm_unreachable("zlib::crc32 is unavailable");
-}
#endif
diff --git a/llvm/unittests/Support/CompressionTest.cpp b/llvm/unittests/Support/CompressionTest.cpp
index 4c351cfbb70fb..777ec00f9efd4 100644
--- a/llvm/unittests/Support/CompressionTest.cpp
+++ b/llvm/unittests/Support/CompressionTest.cpp
@@ -63,12 +63,6 @@ TEST(CompressionTest, Zlib) {
TestZlibCompression(BinaryDataStr, zlib::DefaultCompression);
}
-TEST(CompressionTest, ZlibCRC32) {
- EXPECT_EQ(
- 0x414FA339U,
- zlib::crc32(StringRef("The quick brown fox jumps over the lazy dog")));
-}
-
#endif
}
More information about the llvm-commits
mailing list