[PATCH] D127779: [LTO][ELF] Add --lto-exit-on option

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 10:08:14 PDT 2022


MaskRay added a comment.

In D127779#3637851 <https://reviews.llvm.org/D127779#3637851>, @Northbadge wrote:

> In D127779#3637825 <https://reviews.llvm.org/D127779#3637825>, @MaskRay wrote:
>
>> I can see that fine-grained --save-temps=xxx is useful, but the utility of --lto-exit-on is unclear. Why is the overhead considered so high that an option needs to be added?
>
> It is admittedly more of a nice-to-have development tool/utility. On a 128 thread machine (with enough memory) the difference between having it vs not having it for the "exit on import" case with Chrome (~30k modules) is 1m20s vs 2m20s; extrapolating the parallelized portion to a more conventional 16 thread cpu that'd be a ~5 minute difference instead

And this seems specific to in-process ThinLTO. A distributed ThinLTO (usually they should use this if their executable is large) ThinLTO does not need this. So this feature seems more restricted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127779/new/

https://reviews.llvm.org/D127779



More information about the llvm-commits mailing list